Use encoding objects for comparison instead of encoding names #2418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the names is much less efficient than comparing the instance directly. It may also change in the future: https://bugs.ruby-lang.org/issues/18576
p-mongo
approved these changes
Feb 17, 2022
comandeo
approved these changes
Feb 17, 2022
|
To clarify, the primary purpose of this change is to permit Ruby to possibly rename ascii-8bit encoding into binary at some point in the future. The performance impact of this comparison is not significant because it happens in the test suite. |
p-mongo
changed the title
Yeah sorry. I just sent 31 similar pull requests, so I just copy pasted the commit message. |
neilshweky
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the names is much less efficient than
comparing the instance directly.
It may also change in the future: https://bugs.ruby-lang.org/issues/18576