Skip to content

Explicitly specify python2 for ubuntu2004 #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Feb 23, 2022

No description provided.

Copy link
Contributor

@neilshweky neilshweky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you mind putting a small explanation of why this is necessary in the PR for our future selves?

@p-mongo
Copy link
Contributor Author

p-mongo commented Feb 25, 2022

That is actually a good question. I believe the reason python 2 is currently used is because at some point in the past, some distros (like ubuntu1204 for example) shipped ancient python 3 that didn't work, and to avoid tracking which python we are using we simply used python 2 everywhere. It is likely that on all of the currently used oses there is a recent enough python 3 such that the use of python 2 is no longer necessary.

@p-mongo
Copy link
Contributor Author

p-mongo commented Feb 25, 2022

But, the reason for this particular PR is that newer distros (ubuntu2004) does not contain a python binary, requiring us to explicitly specify python2 or python3.

@p-mongo
Copy link
Contributor Author

p-mongo commented Feb 25, 2022

I just realized that the issue only occurs in docker, not in evergreen. An alternate fix would have been to install python-is-python2 in docker. But I like explicitly specifying the python version more.

@p-mongo p-mongo requested a review from neilshweky February 25, 2022 15:40
Copy link
Contributor

@neilshweky neilshweky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@p-mongo p-mongo merged commit 48785a9 into mongodb:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants