Skip to content

RUBY-2899 Fix comment helper specification tests #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

comandeo
Copy link

No description provided.

@comandeo comandeo marked this pull request as ready for review February 25, 2022 10:53
@neilshweky neilshweky changed the title RUBY-2859 Fix comment helper specification tests RUBY-2899 Fix comment helper specification tests Feb 25, 2022
Copy link
Contributor

@neilshweky neilshweky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you filed a ticket for the ruby driver to group commands in bulk writes?

Also, I changed your PR title because it referenced the wrong ticket

@comandeo comandeo merged commit 5481557 into mongodb:master Feb 25, 2022
@comandeo comandeo deleted the RUBY-2899 branch February 25, 2022 16:52
@comandeo
Copy link
Author

Thank you! I filed drivers ticked for this - https://jira.mongodb.org/browse/DRIVERS-2215, a Ruby one will be split from it when it's the drivers one is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants