Skip to content

RUBY-3079 Propagate Original Error for Write Errors Labeled NoWritesPerformed #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2022
Merged

RUBY-3079 Propagate Original Error for Write Errors Labeled NoWritesPerformed #2616

merged 3 commits into from
Sep 9, 2022

Conversation

neilshweky
Copy link
Contributor

No description provided.

neilshweky
neilshweky commented Sep 9, 2022
View reviewed changes
p-mongo
p-mongo approved these changes Sep 9, 2022
View reviewed changes
spec/integration/retryable_writes_errors_spec.rb Outdated
@@ -31,4 +31,61 @@
end
end
end

context "when encountering a WriteConcernError with a RetryableWriteError label" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this say something about NoWritesPerformed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@neilshweky neilshweky merged commit 135e299 into mongodb:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-mongo p-mongo p-mongo approved these changes

@comandeo comandeo Awaiting requested review from comandeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilshweky @p-mongo