RUBY-3226 Update libmongocrypt payloads to new QE protocol #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they do a funky thing where they treat nil values as implying the absence of a field; had to do some work arounds to make that work. Hopefully it doesn't break anything new...
comandeo
approved these changes
May 25, 2023
spec/integration/client_side_encryption/automatic_data_encryption_keys_prose_spec.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps libmongocrypt to 1.8.0 and updates the spec files required by both RUBY-3226 and RUBY-3211. (There was significant overlap between the two tickets, and they wound up being interdependent.)
There is some noise in the prose specs from updating the specs to satisfy rubocop. The primary things to look for when reviewing this PR are:
min_server_versionof7.0.0-rc0.eccCollectioncollection is no longer created (per the updated spec). Seespec/support/crypt/encrypted_fields/encryptedFields.jsonandQueryableEncryption#emm_collections.lib/mongo/collection/queryable_encryption.rb.spec/runners/transactions/test.rbwas changed to avoid a hard-coded comparison on a YAML spec filename (which caused a mysterious failure when the fle2 filenames changed to fle2v2). The new API allows you to specify a Proc instance asexpectations_bson_types, and the proc is then called with the test instance as an argument. To see this in practice, seespec/spec_tests/client_side_encryption_spec.rb.There are some spec failures, but I can't reproduce them locally. I've added a separate ticket for those, here: https://jira.mongodb.org/browse/RUBY-3265
Ref: https://jira.mongodb.org/browse/RUBY-3226, https://jira.mongodb.org/browse/RUBY-3211