RUBY-945 Add #database_names and #list_databases methods to Client and #list_collections method to Database #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| # @since 2.0.5 | ||
| def database_names | ||
| Database.new(self, Database::ADMIN, options).command( |
There was a problem hiding this comment.
Instead of constructing a new Database what do you think about consuming our own API and using #use here? Ex:
use(Database::ADMIN).command(listDatabases: 1).first['databases'].collect{ |info| info['name'] }There was a problem hiding this comment.
yes, that's better, thanks!
estolfo
force-pushed
the
RUBY-945-database-names
branch
2 times, most recently
from
d0c1669 to
f808922
Compare
estolfo
changed the title
estolfo
force-pushed
the
RUBY-945-database-names
branch
2 times, most recently
from
2c99ef2 to
324ffd6
Compare
estolfo
force-pushed
the
RUBY-945-database-names
branch
from
324ffd6 to
300cb5b
Compare
estolfo
changed the title
estolfo
force-pushed
the
RUBY-945-database-names
branch
from
c0ee361 to
c4e0c46
Compare
estolfo
changed the title
estolfo
changed the title
estolfo
added a commit
that referenced
this pull request
Jun 11, 2015
RUBY-945 Add #database_names and #list_databases methods to Client and #list_collections method to Database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.