RUBY-932 Update Server Discovery and Monitoring code and tests #637
Conversation
estolfo
force-pushed
the
RUBY-932-duplicate-servers
branch
5 times, most recently
from
28b3a14 to
24e87cb
Compare
| # @return [ true, false ] If the description is from the server. | ||
| # | ||
| # @since 2.0.6 | ||
| def self?(server) |
There was a problem hiding this comment.
I might change this name to something else, given that self is reserved in Ruby and this might be a bit confusing.
There was a problem hiding this comment.
Changed it to Description#me?(server)
estolfo
force-pushed
the
RUBY-932-duplicate-servers
branch
from
24e87cb to
58def90
Compare
estolfo
changed the title
|
👍 |
| @servers = [] | ||
| @servers_update = Mutex.new |
There was a problem hiding this comment.
I'd just put one big lock around Cluster and do all non-I/O operations (both reads and updates to all data structures) while holding the lock. If you do I/O, drop the lock, do your operation without touching any Cluster data structures, then reacquire the lock in order to update your data structures according to what you discovered from doing the I/O. So, no need to distinguish between these two mutexes, just lock the whole Cluster whenever you touch it.
There was a problem hiding this comment.
Thanks for your review.
I'm not going to take this approach because there is IO in a bunch of places that might not be obvious (like in the instantiation of an Address, for example) and the code would get messy if I was frequently grabbing and releasing the lock in between lines of code in Cluster.
I have taken your suggestion to only use one lock for both the servers and addresses list.
You're also right about having to copy the list. I've added that in as well.
Thanks again!
There was a problem hiding this comment.
Glad I could help!
On Thu, Jun 18, 2015 at 9:43 AM, Emily [email protected] wrote:
In lib/mongo/cluster.rb
#637 (comment)
:@servers = []
@servers_update = Mutex.newThanks for your review.
I'm not going to take this approach because there is IO in a bunch of
places that might not be obvious (like in the instantiation of an Address,
for example) and the code would get messy if I was frequently grabbing and
releasing the lock in between lines of code in Cluster.I have taken your suggestion to only use one lock for both the servers and
addresses list.You're also right about having to copy the list. I've added that in as
well.Thanks again!
—
Reply to this email directly or view it on GitHub
https://github.com/mongodb/mongo-ruby-driver/pull/637/files#r32730474.
estolfo
force-pushed
the
RUBY-932-duplicate-servers
branch
from
d633fae to
3f72d31
Compare
RUBY-932 Update Server Discovery and Monitoring code and tests
No description provided.