RUBY-912 Use electionId from server descriptions to detect stale primaries #644
+420
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
force-pushed
the
RUBY-912-election-id
branch
from
4f3a427 to
f28c0aa
Compare
|
Looks good. |
estolfo
force-pushed
the
RUBY-912-election-id
branch
from
f28c0aa to
9dec540
Compare
estolfo
added a commit
that referenced
this pull request
Jul 1, 2015
RUBY-912 Use electionId from server descriptions to detect stale primaries
| end | ||
| @max_election_id = description.election_id |
There was a problem hiding this comment.
I think this is different from the spec, which says maxElectionId is "The largest electionId ever reported by a primary." In the spec's pseudocode it only updates maxElectionId if the primary being elected has an electionId. Here, though, I think you'll set maxElectionId to null if a primary is elected with no electionId. Let me write up a test that shows what I mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.