Skip to content

RUBY-1016 Don't check the 'ok' field in query operation validation #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/mongo/operation/read/query.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

require 'mongo/operation/read/query/result'

module Mongo
module Operation
module Read
Expand Down
40 changes: 40 additions & 0 deletions lib/mongo/operation/read/query/result.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright (C) 2014-2015 MongoDB, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

module Mongo
module Operation
module Read
class Query

# Defines custom behaviour of results for a query.
#
# @since 2.1.0
class Result < Operation::Result

# Determine if the query was a success.
#
# @example Was the query successful?
# result.successful?
#
# @return [ true, false ] If the query was successful.
#
# @since 2.0.0
def successful?
!query_failure? && parser.message.empty?
end
end
end
end
end
end
19 changes: 19 additions & 0 deletions spec/mongo/operation/read/query_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,25 @@
op.execute(primary_context)
end
end

context "when the document contains an 'ok' field" do

before do
authorized_collection.insert_one(ok: false)
end

after do
authorized_collection.delete_many
end

let(:context) do
authorized_client.cluster.next_primary.context
end

it 'does not raise an exception' do
expect(op.execute(context)).to be_a(Mongo::Operation::Read::Query::Result)
end
end
end
end