-
Notifications
You must be signed in to change notification settings - Fork 533
RUBY-1021 Use Redacted options class to redact option fields when printing #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be8babf
to
be3eaaf
Compare
I envisioned that we would only need to do this in places where the user provides the options, such as:
And methods like
|
ok @durran, I've made all the suggested changes. Let me know if it looks good. EDIT: I'm actually not convinced this is a good solution. I've realized after testing on jenkins that ssl doesn't work because ssl_options eventually becomes a hash with string keys. I can implement #reject on Options::Redacted to avoid this but it still seems like this is, in general, a fragile solution. |
030c120
to
ffa6d15
Compare
def reject! | ||
if block_given? | ||
n_keys = keys.size | ||
self.keys.each do |key| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need the self
in front of anything but the self[key]
and the direct reference.
2474f21
to
42b6283
Compare
RUBY-1021 Use Redacted options class to redact option fields when printing
No description provided.