Skip to content

Stop monitor on server garbage collection. #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2015
Merged

Stop monitor on server garbage collection. #730

merged 5 commits into from
Nov 29, 2015

Conversation

durran
Copy link
Member

@durran durran commented Nov 27, 2015

  • Stops server monitor when Server is marked for GC.
  • Scopes connection pools to cluster and fixes the Address equality as hash keys bug (was leaking pools)

@durran durran changed the title [DNM] Stop monitor on server garbage collection. Stop monitor on server garbage collection. Nov 29, 2015
durran added a commit that referenced this pull request Nov 29, 2015
Stop monitor on server garbage collection.
@durran durran merged commit eece2a7 into master Nov 29, 2015
@durran durran deleted the finalize-monitor branch November 29, 2015 10:48
@jonhyman
Copy link
Contributor

@durran are you going to support multiple authentications per cluster? This branch still creates num_databases connection pools to a host:ip cluster, since each one gets created as a new Client which creates a new Cluster (and a new ConnectionPool).

Just trying to figure out if I should monkey patch a fork of the driver, as we cannot use this unless it makes fewer connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants