Skip to content

SWIFT-143: ReadPreference option for core classes and operations #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2018
Merged

SWIFT-143: ReadPreference option for core classes and operations #86

merged 2 commits into from
Jul 9, 2018

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jul 6, 2018

https://jira.mongodb.org/browse/SWIFT-143

I believe this covers all of the relevant helper methods currently in the driver:

  • MongoDatabase.runCommand()
  • MongoCollection.aggregate()
  • MongoCollection.count()
  • MongoCollection.distinct()
  • MongoCollection.find()

Per the database, collection, and index enumeration specs, those operations must be executed on a primary server (unless connected to a secondary in standalone mode). In any event, they do not use a read preference.

@jmikola jmikola requested a review from kmahar July 6, 2018 19:00
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@jmikola jmikola merged commit 16e73ca into mongodb:master Jul 9, 2018
@jmikola jmikola deleted the swift-143 branch July 9, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants