SWIFT-142 Remove dictionary init for document #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
changed the title
mbroadst
reviewed
Jul 9, 2018
| @@ -21,7 +21,7 @@ final class CodecTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testEncodeListDatabasesOptions() throws { | |||
| let options = ListDatabasesOptions(filter: Document(["a": 10]), nameOnly: true, session: ClientSession()) | |||
| let options = ListDatabasesOptions(filter: ["a": 10], nameOnly: true, session: ClientSession()) | |||
There was a problem hiding this comment.
cool, you don't even need an as!
There was a problem hiding this comment.
yup, since the filter param is always a Document the compiler infers it 😀
jmikola
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the non-literal dictionary
init, as well as our single usage of it in the tests.