SWIFT-154: Int should encode as Int32 or Int64 as needed #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
approved these changes
Jul 9, 2018
jmikola
commented
Jul 9, 2018
| /// While the bitwidth of Int is machine-dependent, we assume for simplicity | ||
| /// that it is always 32 bits. Use `Int64` if 64 bits are needed. | ||
| /// An extension of `Int` to represent the BSON Int32 or Int64 type. | ||
| /// The `Int` will be encoded as an Int32 if possible, or an Int64 if necessary. |
There was a problem hiding this comment.
could you please update the doc comment just above this extension to clarify the new behavior?
Done.
mbroadst
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/SWIFT-154