CLOUDP-120435: [Atlas CLI] Telemetry - Set Enabled by Default (#1147)

Johan Steyn · web-flow · commit 9d6b4d5715df · 2022-04-26T11:28:37.000+01:00
diff --git a/internal/cli/default_setter_opts.go b/internal/cli/default_setter_opts.go
@@ -240,9 +240,10 @@ func (opts *DefaultSetterOpts) SetUpMongoSHPath() {
 }
 
 func (opts *DefaultSetterOpts) SetUpTelemetryEnabled() {
-	// TODO: Disabling telemetry by default while work is in progress (will be enabled in CLOUDP-120435)
-	telemetryEnabled := false
+	// Telemetry is enabled by default
+	telemetryEnabled := true
 	if config.IsTelemetryEnabledSet() {
+		// But if telemetry has previously been set, preserve that setting
 		telemetryEnabled = config.TelemetryEnabled()
 	}
 	config.SetTelemetryEnabled(telemetryEnabled)

Original file line number	Diff line number	Diff line change
`@@ -240,9 +240,10 @@ func (opts *DefaultSetterOpts) SetUpMongoSHPath() {`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`func (opts *DefaultSetterOpts) SetUpTelemetryEnabled() {`
`243`		`- // TODO: Disabling telemetry by default while work is in progress (will be enabled in CLOUDP-120435)`
`244`		`- telemetryEnabled := false`
	`243`	`+ // Telemetry is enabled by default`
	`244`	`+ telemetryEnabled := true`
`245`	`245`	`if config.IsTelemetryEnabledSet() {`
	`246`	`+ // But if telemetry has previously been set, preserve that setting`
`246`	`247`	`telemetryEnabled = config.TelemetryEnabled()`
`247`	`248`	`}`
`248`	`249`	`config.SetTelemetryEnabled(telemetryEnabled)`