Skip to content

CLOUDP-120435: [Atlas CLI] Telemetry - Set Enabled by Default #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

CLOUDP-120435: [Atlas CLI] Telemetry - Set Enabled by Default #1147

merged 1 commit into from
Apr 26, 2022

Conversation

johansteyn
Copy link
Contributor

@johansteyn johansteyn commented Apr 26, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-120435

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@johansteyn johansteyn requested a review from a team April 26, 2022 09:44
gssbzn
gssbzn requested changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect telemetry to be a global setting but somehow it's per profile, can we please fix that here? you can check how we do it for MongoShellPath to make that one global

gssbzn
gssbzn approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I misread the code seems it's actually global, LGTM

@johansteyn johansteyn merged commit 9d6b4d5 into master Apr 26, 2022
@johansteyn johansteyn deleted the CLOUDP-120435 branch April 26, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johansteyn @gssbzn