CLOUDP-114066: [MongoCLI] The json file of the download center doesn’t contain the release version (#1008)

Author: andreaangiolillo

build/ci/release.yml

@@ -151,9 +151,7 @@ functions:
           export GOROOT="${go_root}"
           export PATH="./bin:${go_bin}:$PATH"
 
-          VERSION=$(git describe | cut -d "v" -f 2)
-
-          go run ../internal/release/main.go "${VERSION}" "${FEED_FILE_NAME}"
+          go run ../internal/release/main.go --version "$(git describe | cut -d "v" -f 2)" --file "${FEED_FILE_NAME}"
   "upload dist":
     - command: s3.put
       params:

internal/flag/flags.go

@@ -270,4 +270,5 @@ const (
 	WithoutDefaultAlertSettings              = "withoutDefaultAlertSettings"     // WithoutDefaultAlertSettings flag
 	CurrentIP                                = "currentIp"                       // CurrentIP flag
 	Gov                                      = "gov"                             // Gov flag
+	Version                                  = "version"                         // Version flag
 )

internal/release/main.go

@@ -20,10 +20,18 @@ import (
 	"os"
 	"strings"
 	"time"
+
+	"github.com/mongodb/mongocli/internal/flag"
+	"github.com/spf13/cobra"
 )
 
 const mongocli = "mongocli"
 
+type Opts struct {
+	fileName string
+	version  string
+}
+
 type DownloadArchive struct {
 	PreviousReleasesLink string     `json:"previous_releases_link"`
 	ReleaseDate          time.Time  `json:"release_date"`
@@ -51,21 +59,21 @@ type Link struct {
 	Name         string `json:"name"`
 }
 
-func newPlatform(tool, version, arch, system, distro string, formats []string) *Platform {
+func newPlatform(packageName, version, arch, system, distro string, formats []string) *Platform {
 	p := &Platform{}
 	p.Arch = arch
 	p.OS = distro
 
 	links := make([]Link, len(formats))
 	for i, f := range formats {
 		links[i] = Link{
-			DownloadLink: fmt.Sprintf("https://fastdl.mongodb.org/mongocli/%s_%s_%s_%s.%s", tool, version, system, arch, f),
+			DownloadLink: fmt.Sprintf("https://fastdl.mongodb.org/mongocli/%s_%s_%s_%s.%s", packageName, version, system, arch, f),
 			Name:         f,
 		}
 	}
 
 	title := "MongoDB Atlas CLI"
-	if tool == mongocli {
+	if packageName == mongocli {
 		title = "MongoDB CLI"
 	}
 	p.Packages = Package{
@@ -76,17 +84,11 @@ func newPlatform(tool, version, arch, system, distro string, formats []string) *
 }
 
 func main() {
-	version := os.Args[1]
-	feedFilename := os.Args[2]
-	fmt.Printf("Generating JSON: %s\n", feedFilename)
-	err := generateFile(feedFilename, version)
-
-	if err != nil {
+	cmd := Builder()
+	if err := cmd.Execute(); err != nil {
 		fmt.Printf("error encoding file: %v\n", err)
-
 		os.Exit(1)
 	}
-	fmt.Printf("File %s has been generated\n", feedFilename)
 }
 
 func generateFile(name, version string) error {
@@ -119,3 +121,28 @@ func generateFile(name, version string) error {
 	jsonEncoder.SetIndent("", "  ")
 	return jsonEncoder.Encode(downloadArchive)
 }
+
+func Builder() *cobra.Command {
+	opts := Opts{}
+	cmd := &cobra.Command{
+		Use:   "main",
+		Short: "Generate the download center json file",
+		Example: `
+  Generate the download center json file for mongocli
+  $ main --version 1.23.0 --file mongocli.json`,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			fmt.Printf("Generating JSON: %s\n", opts.fileName)
+			return generateFile(opts.fileName, opts.version)
+		},
+		PostRun: func(cmd *cobra.Command, args []string) {
+			fmt.Printf("File %s has been generated\n", opts.fileName)
+		},
+	}
+
+	cmd.Flags().StringVar(&opts.version, flag.Version, "", "release version.")
+	cmd.Flags().StringVar(&opts.fileName, flag.File, "mongocli.json", "file name of the download center json file.")
+
+	_ = cmd.MarkFlagFilename(flag.File)
+	_ = cmd.MarkFlagRequired(flag.Version)
+	return cmd
+}

internal/release/main_test.go

@@ -0,0 +1,34 @@
+// Copyright 2022 MongoDB Inc
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build unit
+// +build unit
+
+package main
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongocli/internal/flag"
+	"github.com/mongodb/mongocli/internal/test"
+)
+
+func TestBuilder(t *testing.T) {
+	test.CmdValidator(
+		t,
+		Builder(),
+		0,
+		[]string{flag.Version, flag.File},
+	)
+}