CLOUDP-114066: [MongoCLI] The json file of the download center doesn’t contain the release version #1008
Conversation
| VERSION=$(git describe | cut -d "v" -f 2) | ||
|
|
||
| go run ../internal/release/main.go "${VERSION}" "${FEED_FILE_NAME}" | ||
| go run ../internal/release/main.go --version "$(git describe | cut -d "v" -f 2)" --file "${FEED_FILE_NAME}" |
There was a problem hiding this comment.
git describe may not work anymore with a mono repo
There was a problem hiding this comment.
Looking at the JSON files generated by the package tasks it seems to work properly
There was a problem hiding this comment.
I have also made some tests locally and on evergreen and I haven’t found any issue with git describe
There was a problem hiding this comment.
sorry what I mean is that git describe will get you the latest tag, for now it works since we only release one thing, this may become flaky later
There was a problem hiding this comment.
Thanks for the clarification!
I don't think this is an issue: you are right that the tag returned by git describe will be different when releasing atlascli v0.0.1 as the mongocli.json file will contain the version 0.0.1 when running the packaging tasks. However, this won't happen when running releasing tasks as the latest tag will always be the correct one. Let me know if I am missing something here. Thanks!
There was a problem hiding this comment.
not missing much and why I say may become flaky, race conditions may happen if releasing both the same day
Also this leaves us in a position where master json files will always point to latest, ie, when we do 0.0.1 of atlas we'll have the mongocli json with 0.0.1 as well
There was a problem hiding this comment.
I am going to create a ticket to see how to fix this issue. I will start working on it once I have pre-released atlascli
There was a problem hiding this comment.
|
|
||
| func Builder() *cobra.Command { | ||
| opts := Opts{} | ||
| cmd := &cobra.Command{ |
There was a problem hiding this comment.
[non-blocking] using cobra for this is an overkill if you ask me, you could've used pflags with no need to bring cobra as well
Proposed changes
Jira ticket: CLOUDP-114066
Checklist
make fmtand formatted my codeFurther comments
Issue: We are not adding the release version when generating the download center json file.
{ "previous_releases_link": "https://github.com/mongodb/mongocli/releases", "release_date": "2022-02-28T17:01:01.938089Z", "release_notes_link": "https://docs.mongodb.com/mongocli/v/release-notes/", "tutorial_link": "https://docs.mongodb.com/mongocli/v/quick-start/", "version": "", "manual_link": "https://docs.mongodb.com/mongocli/v/", "platform": [ { "arch": "x86_64", "os": "Linux (x86_64)", "packages": { "title": "MongoDB CLI", "links": [ { "download_link": "https://fastdl.mongodb.org/mongocli/mongocli__linux_x86_64.tar.gz", "name": "tar.gz" } ] } },New download center JSON files: