-
Notifications
You must be signed in to change notification settings - Fork 88
CLOUDP-114080: [Mongocli] Investigate how to get the correct git tag version in evergreen #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…version in evergreen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing this one https://github.com/mongodb/mongocli/blob/master/build/package/generate-msi.sh
probably a good idea to do a search/grep for git describe
in the whole repo to make sure we don't miss one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and godspeed with your first atlas alpha
Proposed changes
Jira ticket: CLOUDP-114080
Checklist
make fmt
and formatted my codeFurther comments
Issue: We have several evergreen tasks that are using git describe to get the latest tag version available. Git describe will get you the latest tag, for now it works since we only release one thing, this may become flaky later. This PR address this comment #1008 (comment)
Nre Version format for non-production binaries:
vX.Y.Z-next
.We use
git describe
if the tag is not found.I have tested my fix using this fork https://github.com/andreaangiolillo/mongocli-test/releases which contains atlascli tags