Fix NPE for atlascli and add tests (#1036)

Author: blva

internal/cli/root/atlas/builder_test.go

@@ -44,7 +44,7 @@ func TestBuilder(t *testing.T) {
 func TestOutputOpts_notifyIfApplicable(t *testing.T) {
 	tests := testCases()
 	for _, tt := range tests {
-		t.Run(fmt.Sprintf("%v / %v", tt.currentVersion, tt.release.GetTagName()), func(t *testing.T) {
+		t.Run(fmt.Sprintf("%v/%v", tt.currentVersion, tt.release), func(t *testing.T) {
 			config.ToolName = config.AtlasCLI
 			prevVersion := version.Version
 			version.Version = tt.currentVersion
@@ -77,7 +77,11 @@ func TestOutputOpts_notifyIfApplicable(t *testing.T) {
 				t.Errorf("notifyIfApplicable() unexpected error:%v", err)
 			}
 
-			v := latestrelease.VersionFromTag(tt.release.GetTagName(), config.ToolName)
+			v := ""
+			if tt.release != nil {
+				v = latestrelease.VersionFromTag(tt.release.GetTagName(), config.ToolName)
+			}
+
 			want := ""
 			if tt.expectNewVersion {
 				want = fmt.Sprintf(`
@@ -126,6 +130,11 @@ func testCases() []testCase {
 			expectNewVersion: false,
 			release:          &github.RepositoryRelease{TagName: &atlasV, Prerelease: &f, Draft: &f},
 		},
+		{
+			currentVersion:   "v3.0.0-123",
+			expectNewVersion: false,
+			release:          nil,
+		},
 	}
 	return tests
 }

internal/cli/root/mongocli/builder_test.go

@@ -134,7 +134,7 @@ func TestBuilder(t *testing.T) {
 func TestOutputOpts_notifyIfApplicable(t *testing.T) {
 	tests := testCases()
 	for _, tt := range tests {
-		t.Run(fmt.Sprintf("%v / %v", tt.currentVersion, tt.release.GetTagName()), func(t *testing.T) {
+		t.Run(fmt.Sprintf("%v/%v", tt.currentVersion, tt.release), func(t *testing.T) {
 			prevVersion := version.Version
 			version.Version = tt.currentVersion
 			defer func() {
@@ -166,7 +166,11 @@ func TestOutputOpts_notifyIfApplicable(t *testing.T) {
 				t.Errorf("notifyIfApplicable() unexpected error:%v", err)
 			}
 
-			v := latestrelease.VersionFromTag(tt.release.GetTagName(), config.ToolName)
+			v := ""
+			if tt.release != nil {
+				v = latestrelease.VersionFromTag(tt.release.GetTagName(), config.ToolName)
+			}
+
 			want := ""
 			if tt.expectNewVersion {
 				want = fmt.Sprintf(`
@@ -221,6 +225,11 @@ func testCases() []testCase {
 			expectNewVersion: false,
 			release:          &github.RepositoryRelease{TagName: &mcliV, Prerelease: &f, Draft: &f},
 		},
+		{
+			currentVersion:   "v3.0.0-123",
+			expectNewVersion: false,
+			release:          nil,
+		},
 	}
 	return tests
 }

internal/latestrelease/finder.go

@@ -103,7 +103,7 @@ func (f *finder) loadOrGet() (*ReleaseInformation, *semver.Version, error) {
 	}
 
 	newestRelease, err := f.find()
-	if err != nil {
+	if err != nil || newestRelease == nil {
 		return nil, nil, err
 	}
 
@@ -126,7 +126,7 @@ func (f *finder) Find() (releaseInfo *ReleaseInformation, err error) {
 	}
 
 	releaseInfo, newestVersion, err := f.loadOrGet()
-	if err != nil || svCurrentVersion.Compare(newestVersion) > 0 {
+	if err != nil || releaseInfo == nil || svCurrentVersion.Compare(newestVersion) > 0 {
 		return nil, err
 	}
 	return releaseInfo, nil