Skip to content

Fix NPE for AtlasCLI and add tests #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix NPE for AtlasCLI and add tests #1036

merged 1 commit into from
Mar 14, 2022

Conversation

blva
Copy link
Collaborator

@blva blva commented Mar 14, 2022

Proposed changes

While testing, noticed that since we discard pre-releases, atlaslci was returning nil and crashing. Added a fix and tests for both mongocli and atlascli

➜  mongocli git:(atlascli-npe-fix) ✗ ./bin/atlas config list
PROFILE NAME
default
test

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva requested a review from a team March 14, 2022 13:29
andreaangiolillo
andreaangiolillo approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit f07ffae into master Mar 14, 2022
@blva blva deleted the atlascli-npe-fix branch March 14, 2022 13:41
blva added a commit that referenced this pull request Mar 14, 2022
@blva
Fix NPE for atlascli and add tests (#1036)
3622e06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blva @andreaangiolillo