Skip to content

CLOUDP-114068: [mcli] drop EOL OSes #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2022
Merged

CLOUDP-114068: [mcli] drop EOL OSes #1007

merged 2 commits into from
Mar 1, 2022

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 1, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-114068

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@gssbzn gssbzn requested a review from a team March 1, 2022 10:03
andreaangiolillo
andreaangiolillo previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gssbzn
gssbzn commented Mar 1, 2022
View reviewed changes
build/ci/release.yml
@@ -339,17 +339,6 @@ tasks:
vars:
image: centos7-rpm
tool_name: mongocli
- name: pkg_test_mongocli_docker_centos8
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centos8 is EOL since January the image is unstable now

gssbzn
gssbzn commented Mar 1, 2022
View reviewed changes
build/ci/release.yml
@@ -599,28 +588,6 @@ tasks:
distro: rhel70
ext: rpm
tool_name: atlascli
- name: push_atlascli_rhel62_org
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rhel 6 has been EOL for a while, time to remove it

@gssbzn gssbzn requested a review from andreaangiolillo March 1, 2022 10:29
andreaangiolillo
andreaangiolillo approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share the file that contains the supported distro? It would be great to add its link somewhere in mongocli so that we can add/remove distros

@gssbzn
Copy link
Collaborator Author

gssbzn commented Mar 1, 2022

Could you share the file that contains the supported distro? It would be great to add its link somewhere in mongocli so that we can add/remove distros

good ask, shared internally

@gssbzn gssbzn merged commit dc613ff into master Mar 1, 2022
@gssbzn gssbzn deleted the CLOUDP-114068 branch March 1, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciprian-tibulca ciprian-tibulca ciprian-tibulca approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gssbzn @ciprian-tibulca @andreaangiolillo