CLOUDP-113344: Improve time of new version checker

[blva]

Proposed changes

Jira ticket: CLOUDP-113344

• Inspiration for the approach -> https://github.com/cli/cli/blob/trunk/cmd/gh/main.go
• Save the latest retrieved version in /Users/<user>/.config/mongocli/rstate.yaml and update it every 24 hours.
• Save the homebrew paths in /Users/<user>/.config/mongocli/brew.yaml and update it every 24 hours.
• Discarted go routine change because 1) It didn't offer considerable time reduction 2) It didn't work for ops-manager/atlas commands.

Checklist

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works
• I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
• I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
• I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
• I have run make fmt and formatted my code

Help me testing this on a non-M1 machine:

• Branch: https://github.com/mongodb/mongodb-atlas-cli/tree/checker-test

git fetch 
git checkout test-version-feature
make build
./bin/mongocli config list

Further comments

• note: first run will still take time as files will be saved for the first time.

Before:

➜ mongocli git[CLOUDP-113344](https://jira.mongodb.org/browse/CLOUDP-113344)) ✗ ./bin/mongocli config list
PROFILE NAME
default
test

A new version of mongocli is available 'v1.23.0'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.

To disable this alert, run "mongocli config set skip_update_check true".
1.53327125s

After (M1)
1st run

➜  mongocli git:(CLOUDP-113344) ✗ mongoclidev config list
PROFILE NAME
default
test

A new version of mongocli is available 'v1.23.1'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.

To disable this alert, run "mongocli config set skip_update_check true".
Feature version checker time: 481.586334ms
➜  mongocli git:(CLOUDP-113344) ✗ mongoclidev config list
PROFILE NAME
default
test

A new version of mongocli is available 'v1.23.1'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.

To disable this alert, run "mongocli config set skip_update_check true".
Feature version checker time: 164.084µs

[andreaangiolillo]

Could you add in the description of the PR the strategy that you have used to improve the timing of this feature? Thanks! : )

[gssbzn]

Thanks for tracking and trying to improve on the timing here, I left some comments on code organization.
I have a couple of recommendations based on what looks to be around abstractions, either premature or leaky.

File saving could be improved, either by relaying on viper, or by making the code less abstract.

I don't think a "printer" abstraction should have access to the file system, this seems to be a leaky abstraction, if the responsability of the interface is to "print" (based on name) it should jsut do that, consider ways to simplify printer and favour composition so that the dependency on the file system can be removed.
Finally lumping brew configs and latest release meta info in the same abstraction may not be the right call, consider if they can be split and just like with printer and the file system think of ways to favour composition over nested dependencies, these problems becomes somewhat evident by looking at this line:

func NewPrinterWithFinder(ctx context.Context, f VersionFinder) Printer {
	return &printer{c: ctx, finder: f, store: NewStore(afero.NewOsFs())}
}

your printer has a direct dependency on "Store" (whatever that may mean) which in turn has a direct dependency on afero, and encapsulating this chain of dependencies is one of the reasons reviewing this PR takes a while as it takes a bit of scrolling around to follow the dependencies and interactions

[andreaangiolillo]

My machine (not M1):

./bin/mongocli config list

PROFILE NAME

A new version of mongocli is available 'v1.23.0'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.

To disable this alert, run "mongocli config set skip_update_check true".
2.29895842s
➜  ~/workspace/mongocli git:(test-version-feature) ./bin/mongocli config list

PROFILE NAME

A new version of mongocli is available 'v1.23.0'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.

To disable this alert, run "mongocli config set skip_update_check true".
343.049µs

[andreaangiolillo]

LGTM

[gssbzn]

Almost there

[gssbzn]

[q] I'm not sure I understand why we store these paths, wouldn't storing isHomebrew: <true|false> be enough?

[blva]

Yes, storing a boolean is enough, will update

[blva]

During the pair programming we ended up leaving both for usage, LMK if you want to still have boolean only stored

[andreaangiolillo]

LGTM. I would wait for Gustavo to review this PR as he paired with you. Thanks for all your work on this one!

[gssbzn]

LGTM comments are not blcoking

[threebee]

restamp