Skip to content

CLOUDP-115561: [Atlas CLI] Add toolName in goreleaser #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 14, 2022

Proposed changes

Jira ticket: CLOUDP-115561

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

During my testing of the release candidate, I have noticed that we are not setting the tool name at build time when releasing atlas cli.

atlas --version
mongocli version: 1.0.0-rc0
git version: 87da56233dfcd1d13aa99b98381f2cbc8e50b010
Go version: go1.17
   os: linux
   arch: amd64
   compiler: gc
ubuntu@ip-10-0-1-10:~$

Solution:
This PR adds the atlascli tool name at build time in the release process.

atlas --version
atlascli version: 1.0.0-rc0
git version: f7d27912cf2cc0151a692fdc74699228b033cf67
Go version: go1.17
   os: darwin
   arch: amd64
   compiler: gc

@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 14, 2022 08:38
@andreaangiolillo andreaangiolillo requested review from a team and gssbzn March 14, 2022 08:38
@andreaangiolillo andreaangiolillo merged commit c709a6b into master Mar 14, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-115561 branch March 14, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants