Skip to content

CLOUDP-115583: [AtlasCLI] Update go releaser for the stable release #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 14, 2022

Proposed changes

Jira ticket: CLOUDP-115583

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

We had set the flag prerelease: true in the atlascli goreleaser file as a precaution. Now that we are ready to release v1.0.0 we have to set prerelease to auto

See goreleaser doc

  # If set to auto, will mark the release as not ready for production
  # in case there is an indicator for this in the tag e.g. v1.0.0-rc1
  # If set to true, will mark the release as not ready for production.
  # Default is false.
  prerelease: auto

@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 14, 2022 15:06
@andreaangiolillo andreaangiolillo requested review from a team and gssbzn March 14, 2022 15:06
@andreaangiolillo andreaangiolillo merged commit c9e7c73 into master Mar 14, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-115583 branch March 14, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants