Skip to content

CLOUDP-115691: [AtlasCLI] remove the iam commands that are not available on atlas #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-115691

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

The following commands are not available on atlas and should be removed from atlascli:

  • globalapikeys
  • globalaccesslists
  • organization.create

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner March 15, 2022 11:54
@andreaangiolillo andreaangiolillo requested a review from a team March 15, 2022 11:54
Comment on lines +53 to +60
cmd.AddCommand(
ListBuilder(),
DescribeBuilder(),
DeleteBuilder(),
apikeys.Builder(),
users.Builder(),
invitations.Builder(),
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organization create is not available on atlas

Comment on lines -148 to 146
globalapikeys.Builder(),
globalaccesslists.Builder(),
organizations.AtlasCLIBuilder(),
users.Builder(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 15, 2022 11:56
@andreaangiolillo andreaangiolillo merged commit 0b00b58 into master Mar 15, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-115691 branch March 15, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants