Skip to content

Release fix: Updated git tag command to use "taggerdate" #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2022
Merged

Release fix: Updated git tag command to use "taggerdate" #1046

merged 2 commits into from
Mar 15, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 15, 2022 •
edited
Loading

Proposed changes

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

When releasing atlascli/v1.0.0 I have noticed that git tag --list 'atlascli/v*' --sort=committerdate was listing the release candidate after the v1.0.0.

git tag --list 'atlascli/v*' --sort=committerdate
atlascli/v0.0.1
atlascli/v1.0.0
atlascli/v1.0.0-rc0
atlascli/v1.0.0-rc1

This PR updates the git tag command to use taggerdate:

git tag --list "atlascli/v*" --sort=taggerdate
atlascli/v0.0.1
atlascli/v1.0.0-rc0
atlascli/v1.0.0-rc1
atlascli/v1.0.0

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 15, 2022 15:13
@andreaangiolillo andreaangiolillo changed the title Relase fix: Updated git tag command to use "taggerdate" Release fix: Updated git tag command to use "taggerdate" Mar 15, 2022
@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 15, 2022 15:57
@andreaangiolillo andreaangiolillo requested a review from a team March 15, 2022 15:57
blva
blva approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! LGTM

@andreaangiolillo andreaangiolillo merged commit 7e7db1c into master Mar 15, 2022
@andreaangiolillo andreaangiolillo deleted the release_fix_tag_version branch March 15, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blva blva blva approved these changes

@gssbzn gssbzn Awaiting requested review from gssbzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @blva