Skip to content

CLOUDP-121186: [AtlasCLI] Update commands's description that still have ops manager #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

CLOUDP-121186: [AtlasCLI] Update commands's description that still have ops manager #1156

merged 1 commit into from
Apr 28, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Apr 28, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-121186

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner April 28, 2022 11:14
@andreaangiolillo andreaangiolillo requested a review from a team April 28, 2022 11:14
swattyT
swattyT approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@swattyT swattyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit dd2a295 into master Apr 28, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-121186 branch April 28, 2022 14:31
@andreaangiolillo
Copy link
Collaborator Author

@sarahsimpers Merging this PR so that it is in the next release. Feel free to add comments to this PR, I will address them in a follow-up PR. Thanks

@sarahsimpers
Copy link
Contributor

@andreaangiolillo Sorry that I missed this somehow! It looks good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swattyT swattyT swattyT approved these changes

@sarahsimpers sarahsimpers Awaiting requested review from sarahsimpers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaangiolillo @sarahsimpers @swattyT