CLOUDP-112245: [Milestone] Atlascli/Mongocli Doc changes #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
requested review from
a team and
fmenezes
and removed request for
a team
Comment on lines
+92
to
+100
| gen-docs: gen-docs-mongocli gen-docs-atlascli ## Generate docs for commands | ||
|
|
||
| gen-docs-mongocli: ## Generate docs for mongocli commands | ||
| @echo "==> Generating docs for mongocli" | ||
| go run ./internal/docs/mongocli/main.go | ||
|
|
||
| gen-docs-atlascli: ## Generate docs for atlascli commands | ||
| @echo "==> Generating docs for atlascli" | ||
| go run ./internal/docs/atlascli/main.go |
There was a problem hiding this comment.
This is one change
internal/docs/atlascli/main.go
Outdated
| // Copyright 2022 MongoDB Inc | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. |
There was a problem hiding this comment.
This is the second change
internal/docs/mongocli/main.go
Outdated
| @@ -31,13 +31,13 @@ func setDisableAutoGenTag(cmd *cobra.Command) { | |||
| } | |||
|
|
|||
| func main() { | |||
| if err := os.RemoveAll("./docs/command"); err != nil { | |||
| if err := os.RemoveAll("./docs/mongocli/command"); err != nil { | |||
There was a problem hiding this comment.
This is the last change
gssbzn
reviewed
Feb 10, 2022
|
they are a reviewer of this PR so we will merge this only when they are ready |
sarahsimpers
approved these changes
Mar 2, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-112245
Checklist
make fmtand formatted my codeFurther comments
Description:
Changes:
docs/commandstodocs/mongocli/commands-> This is a breaking change for the doc tooldocs/atlascli/commands