-
Notifications
You must be signed in to change notification settings - Fork 88
feat: add fig-autocomplete
subcommand
#995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -75,7 +75,6 @@ func UnmanageBuilder() *cobra.Command { | |||
} | |||
cmd := &cobra.Command{ | |||
Use: "unmanage <name>", | |||
Aliases: []string{"rm"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This alias name was also aliased in the "delete" subcommand which was shadowing this one, so removing this alias should not be breaking.
de3c55c
to
e8543de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for keep you waiting we were wrapping a couple of other things and I was waiting some confirmations from product about enabling this for mongocli but given withfig/autocomplete#972 was merged I think that ship has sailed now
I have verified the CLA so merging this |
Hi @fedeci I understand this PR is for mongocli. Can we please revert these changes as per my email some time ago? We'll keep it only for the Atlas CLI. |
Sure @boooczek! |
Proposed changes
Add Fig integration to generate a fig spec when
mongocli fig-autocomplete
is run.This is far by actually providing the full integration with autocomplete repo, but I prefer to split it in smaller PRs that can be merged faster.
Checklist
make fmt
and formatted my codeFurther comments