Skip to content

feat: add fig-autocomplete subcommand #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

fedeci
Copy link
Contributor

@fedeci fedeci commented Feb 24, 2022

Proposed changes

Add Fig integration to generate a fig spec when mongocli fig-autocomplete is run.
This is far by actually providing the full integration with autocomplete repo, but I prefer to split it in smaller PRs that can be merged faster.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fedeci fedeci requested a review from a team February 24, 2022 18:53
@@ -75,7 +75,6 @@ func UnmanageBuilder() *cobra.Command {
}
cmd := &cobra.Command{
Use: "unmanage <name>",
Aliases: []string{"rm"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alias name was also aliased in the "delete" subcommand which was shadowing this one, so removing this alias should not be breaking.

@fedeci fedeci force-pushed the feat/fig-autocompletion branch from de3c55c to e8543de Compare February 25, 2022 13:15
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for keep you waiting we were wrapping a couple of other things and I was waiting some confirmations from product about enabling this for mongocli but given withfig/autocomplete#972 was merged I think that ship has sailed now

@gssbzn
Copy link
Collaborator

gssbzn commented Mar 4, 2022

I have verified the CLA so merging this

@gssbzn gssbzn merged commit 82cbe6f into mongodb:master Mar 4, 2022
@fedeci fedeci deleted the feat/fig-autocompletion branch March 4, 2022 10:36
@boooczek
Copy link

Hi @fedeci I understand this PR is for mongocli. Can we please revert these changes as per my email some time ago? We'll keep it only for the Atlas CLI.

@fedeci
Copy link
Contributor Author

fedeci commented Mar 28, 2022

Sure @boooczek!
According to the emails you prefer not to add fig integration to mongocli because it is a further dependency. What do you think about integrating it only in development builds (in this manner it would not be added to deps) so that you can still generate the specs in CI and automatically push them to autocomplete repo?
For the moment I am reverting these changes, please let me know what do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants