Update PR template for new etiquette guidelines #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roothorp
changed the title
roothorp
requested review from
helderjs,
s-urbaniak,
josvazg and
igor-karpukhin
josvazg
reviewed
Feb 5, 2025
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| ## Reminder (Please remove this when merging) | ||
| - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible | ||
| - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) |
There was a problem hiding this comment.
This link will not work for external contributors, I would remove it.
|
This PR has gone 30 days without any activity and meets the project’s definition of 'stale'. This will be auto-closed if there is no new activity over the next 60 days. If the issue is still relevant and active, you can simply comment with a 'bump' to keep it open. Thanks for keeping our repository healthy! |
|
@roothorp is this still in progress? |
josvazg
approved these changes
Mar 20, 2025
roothorp
force-pushed
the
update-pr-template
branch
from
96b0b45 to
6c87f5c
Compare
s-urbaniak
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).