Skip to content

CLOUDP-299772: Remove last skipped config #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 26, 2025
Merged

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Mar 11, 2025

Replace it by:

  • Clearing the resource lists for migrated independent CRDs at skip time. So that they will not eagerly try to take over the full resource list when skip is removed and potentially conflict with existing independent CRs.
  • Without last applied config, non greediness behaviour kicks in and the legacy embedded resource controller will not delete resources from Atlas that does not know about.

Testing: Added one test verifying that migrated resource lists get cleared when the project reconcile is skipped, and several tests cases per migrated resource to verify non greedy behaviour conforms to expectations.

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg requested a review from a team as a code owner March 11, 2025 10:01
@josvazg josvazg marked this pull request as draft March 11, 2025 10:01
@josvazg josvazg changed the title CLOUDP: Remove last applied config [WIP] CLOUDP: Remove last applied config Mar 11, 2025
@josvazg josvazg changed the title [WIP] CLOUDP: Remove last applied config [WIP] CLOUDP-299772: Remove last applied config Mar 11, 2025
@josvazg josvazg added the cloud-tests Run expensive Cloud Tests: Integration & E2E label Mar 11, 2025
@josvazg josvazg temporarily deployed to openshift-test March 11, 2025 10:36 — with GitHub Actions Inactive
@josvazg josvazg merged commit 54091db into main Mar 26, 2025
62 checks passed
@josvazg josvazg deleted the CLOUDP-299772/rm-last-skipped branch March 26, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants