-
Notifications
You must be signed in to change notification settings - Fork 93
CLOUDP-304211: Only accept pull_request_target with safe-to-test label #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0599e1d
to
bda5f75
Compare
And exclude the pr evertn when safe-to-test is set Signed-off-by: jose.vazquez <[email protected]>
bda5f75
to
18fd2e6
Compare
Signed-off-by: jose.vazquez <[email protected]>
6e93ef3
to
38a3704
Compare
The only way to activate this change and test it is by merging it first, unfortunately. This is because the |
s-urbaniak
approved these changes
Mar 21, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a new small
trigger.yml
workflow to handle the logic for bothpull_request
&pull_request_target
separately of other ways to trigger thetest.yml
workflow. There are only 2 scenarios allowed:pull_request
events without thesafe-to-test
label, intended for code owner contributions. Uses the incoming change repo creds, which is the same, as the PR comes from a branch in the same repo.pull_request_target
events withsafe-to-test
label that a code owner have just set. Uses the target repo creds, that is the AKO repo creds, and is intended to allow contributions to be tested once a code owner decides it is safe to do so.All Submissions: