Skip to content

CLOUDP-309306: Project reconciler incorrectly sets PE status for unmanaged resources #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

helderjs
Copy link
Collaborator

Summary

The project reconciler sets a status condition for a resource it does not manage. Without the corresponding configuration, the reconciler is unable to track the resource properly, preventing the project from reaching a ready state.

Proof of Work

Incremented unit test covering more greedy behavior cases

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@helderjs helderjs requested a review from a team as a code owner March 27, 2025 20:17
@helderjs helderjs force-pushed the CLOUDP-309306-fix-project-pe-status branch from e3cc5cf to 0d150b3 Compare March 27, 2025 20:21
@helderjs helderjs force-pushed the CLOUDP-309306-fix-project-pe-status branch from 0d150b3 to 73462f1 Compare March 27, 2025 20:26
@helderjs helderjs requested a review from s-urbaniak March 28, 2025 13:47
@helderjs helderjs merged commit 86a84d7 into main Mar 31, 2025
61 of 62 checks passed
@helderjs helderjs deleted the CLOUDP-309306-fix-project-pe-status branch March 31, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants