Skip to content

CLOUDP-313350: Fix the commit sign base64 encoding #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Apr 22, 2025

Summary

Must use base64 -w0 to avoid new lines in commits with long changes. before that, the base64 encoding adding EOLs to the encoded output was breaking requests sent to GitHub.

Also fixed some formatting whitespacing and EOLs.

Proof of Work

Test commit generated in test repo Commit generating test job

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@josvazg josvazg requested a review from a team as a code owner April 22, 2025 14:30
@josvazg josvazg force-pushed the CLOUDP-313350/ako-releaser-signs-commits-2 branch from 894349f to e5f82f1 Compare April 22, 2025 16:13
@josvazg josvazg changed the title CLOUDP-313350: Fix the commit sign fix by removing EOLs CLOUDP-313350: Fix the commit sign fix base64 encoding Apr 22, 2025
@josvazg josvazg force-pushed the CLOUDP-313350/ako-releaser-signs-commits-2 branch from e5f82f1 to 606a3c1 Compare April 22, 2025 16:20
@josvazg josvazg changed the title CLOUDP-313350: Fix the commit sign fix base64 encoding CLOUDP-313350: Fix the commit sign base64 encoding Apr 22, 2025
# Create blob and tree
NEW_TREE_ARRAY="["
for FILE_PATH in $MODIFIED_FILES; do
# Read file content encoded to base64
ENCODED_CONTENT=$(base64 < "${FILE_PATH}")

ENCODED_CONTENT=$(base64 -w0 < "${FILE_PATH}")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @roothorp this is the actual fix, all the rest are formatting fixes

@josvazg josvazg merged commit 208807e into main Apr 22, 2025
18 checks passed
@josvazg josvazg deleted the CLOUDP-313350/ako-releaser-signs-commits-2 branch April 22, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants