Skip to content

CLOUDP-318983: Fixed typo in tag values for deployments #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

CLOUDP-318983: Fixed typo in tag values for deployments #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
436105b
CLOUDP-318983: Fixed typo in tag values for deployments
igor-karpukhin May 15, 2025
148e9a1
Update the base for deployment crd
igor-karpukhin May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1/atlasdeployment_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ type TagSpec struct {
Key string `json:"key"`
// +kubebuilder:validation:MaxLength:=255
// +kubebuilder:validation:MinLength:=1
// +kubebuilder:validation:Pattern:=^[a-zA-Z0-9][a-zA-Z0-9@_.+`;`-]*$
// +kubebuilder:validation:Pattern:=^[a-zA-Z0-9][a-zA-Z0-9 @_.+`;`-]*$
Value string `json:"value"`
}

Expand Down
6 changes: 3 additions & 3 deletions config/crd/bases/atlas.mongodb.com_atlasdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ spec:
value:
maxLength: 255
minLength: 1
pattern: ^[a-zA-Z0-9][a-zA-Z0-9@_.+`;`-]*$
pattern: ^[a-zA-Z0-9][a-zA-Z0-9 @_.+`;`-]*$
type: string
required:
- key
Expand Down Expand Up @@ -676,7 +676,7 @@ spec:
value:
maxLength: 255
minLength: 1
pattern: ^[a-zA-Z0-9][a-zA-Z0-9@_.+`;`-]*$
pattern: ^[a-zA-Z0-9][a-zA-Z0-9 @_.+`;`-]*$
type: string
required:
- key
Expand Down Expand Up @@ -895,7 +895,7 @@ spec:
value:
maxLength: 255
minLength: 1
pattern: ^[a-zA-Z0-9][a-zA-Z0-9@_.+`;`-]*$
pattern: ^[a-zA-Z0-9][a-zA-Z0-9 @_.+`;`-]*$
type: string
required:
- key
Expand Down
6 changes: 1 addition & 5 deletions test/int/deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment", "deployment-
secret.StringData = secretData()
})
Expect(err).To(BeNil())

})

By("Checking that the Deployment is deleted", func() {
Expand Down Expand Up @@ -722,7 +721,7 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment", "deployment-

By("Updating the Deployment tags", func() {
createdDeployment = performUpdate(ctx, 30*time.Minute, client.ObjectKeyFromObject(createdDeployment), func(deployment *akov2.AtlasDeployment) {
deployment.Spec.DeploymentSpec.Tags = []*akov2.TagSpec{{Key: "test-1", Value: "value-1"}, {Key: "test-2", Value: "value-2"}}
deployment.Spec.DeploymentSpec.Tags = []*akov2.TagSpec{{Key: "test 1", Value: "value 1"}, {Key: "test-2", Value: "value-2"}}
})
doDeploymentStatusChecks()
checkAtlasState(func(c *admin.AdvancedClusterDescription) {
Expand Down Expand Up @@ -970,7 +969,6 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment", "deployment-

Describe("Setting the deployment skip annotation should skip reconciliations.", func() {
It("Should Succeed", func(ctx context.Context) {

By(`Creating the deployment with reconciliation policy "skip" first`, func() {
createdDeployment = akov2.DefaultAWSDeployment(namespace.Name, createdProject.Name).Lightweight()
performCreate(createdDeployment, 30*time.Minute)
Expand Down Expand Up @@ -1356,7 +1354,6 @@ var _ = Describe("AtlasDeployment", Ordered, Label("int", "AtlasDeployment", "de
}
return nil
}).WithTimeout(5 * time.Minute).WithPolling(5 * time.Second).Should(Not(HaveOccurred()))

})
})
})
Expand Down Expand Up @@ -1443,7 +1440,6 @@ var _ = Describe("AtlasDeployment", Ordered, Label("int", "AtlasDeployment", "de
}
})
Expect(err).To(BeNil())

})

By("Deployment is ready with backup and snapshot distribution configured", func() {
Expand Down
Loading