Skip to content

Adding ability to add extraEnvs for Atlas Operator deployment #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

orangesqueeze
Copy link
Contributor

Summary

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@orangesqueeze orangesqueeze requested a review from a team as a code owner May 21, 2025 08:26
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! LGTM from my side but I'd like to have another pair of eyes here as well.

@s-urbaniak
Copy link
Collaborator

@orangesqueeze another request: would you mind to sign your commit? see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits, it's a prerequisite for us.

@orangesqueeze orangesqueeze force-pushed the cdumitrescu-patch-1 branch 2 times, most recently from 02dab05 to 17cb8d3 Compare May 21, 2025 12:40
@orangesqueeze orangesqueeze force-pushed the cdumitrescu-patch-1 branch from 17cb8d3 to 0f877e1 Compare May 21, 2025 12:49
@orangesqueeze
Copy link
Contributor Author

@orangesqueeze another request: would you mind to sign your commit? see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits, it's a prerequisite for us.

@s-urbaniak done

@s-urbaniak s-urbaniak merged commit 9834703 into mongodb:main May 21, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants