Skip to content

CLOUDP-320196: fix skew detection for disabled compute autoscaling #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

s-urbaniak
Copy link
Collaborator

@s-urbaniak s-urbaniak commented May 23, 2025

Summary

This fixes skew detection if compute autoscaling is disabled but the user still configures remaining autoscaling fields (like instance sizes).

Previously, skew was always detected, causing indefinite reconciles. See the referenced HELP ticket for more details.

Proof of Work

Added new unit test and changed existing unit tests reflecting the changed translation layer behavior.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@s-urbaniak s-urbaniak requested a review from a team as a code owner May 23, 2025 09:27
@s-urbaniak s-urbaniak changed the title fix skew detection for disabled compute autoscaling HELP-75800: fix skew detection for disabled compute autoscaling May 23, 2025
@s-urbaniak s-urbaniak changed the title HELP-75800: fix skew detection for disabled compute autoscaling CLOUDP-320196: fix skew detection for disabled compute autoscaling May 23, 2025
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more smart fixup

@s-urbaniak
Copy link
Collaborator Author

@josvazg yes 😞

@s-urbaniak s-urbaniak merged commit 21afe33 into main May 23, 2025
69 checks passed
@s-urbaniak s-urbaniak deleted the HELP-75800 branch May 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants