CLOUDP-316083: Add Unified State Machine support libraries #2359
Conversation
| if u, ok := clientObj.(*unstructured.Unstructured); ok { | ||
| u.SetGroupVersionKind(r.unstructuredGVK) | ||
| } |
There was a problem hiding this comment.
q: Why do you need this check?
There was a problem hiding this comment.
This came straight from the PoC using unstructured CRDs, I believe we do not need it for our controllers, but...
Qe might still test with unstructured data sometime?
I will let @s-urbaniak chime in to confirm whether or not we might need this going forward, even if not for production code.
There was a problem hiding this comment.
this is needed if we are reconciling unstructured. For unstructured objects we must set the GVK otherwise the underlying shared index informer won't be able to find it in the cache, it won't know what type it is.
There was a problem hiding this comment.
Yet the question remains, are we going to use unstructured at all? when?
I suspect we might use it for some experiments on the side. This being expected to be a library I guess it merits the flexibility to support unstructured. Right?
There was a problem hiding this comment.
i think it is fine to leave the support for unstructured, mostly for proof of concepts.
Summary
Add support for the Unified State Machine.
Proof of Work
This has been tested in #2313
Checklist