CLOUDP-221656: Added an openshift test cleaner to the regular cleaner job #2360
Conversation
.github/workflows/cleanup-test.yml
Outdated
| @@ -48,6 +48,12 @@ jobs: | |||
|
|
|||
| echo credentials=$(realpath ~/gcp_sa_cred.json) >> $GITHUB_OUTPUT | |||
|
|
|||
| - name: Download tools for openshift test cleaner | |||
| run: | | |||
| wget https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/latest-4.6/openshift-client-linux.tar.gz -O openshift.tar.gz -q | |||
There was a problem hiding this comment.
4.6 is very old, also I am a bit concerned about keeping this up-to-date. Can't we inline this in the script itself?
There was a problem hiding this comment.
This is from the upgrade test, which still works. We use a limited set of OC commands. But we can bump them to the latest one
There was a problem hiding this comment.
There was a problem hiding this comment.
I think we can, but this is only needed for this script. You can't launch it locally anyway
| else | ||
| for ns in $namespaces; do | ||
| echo "Deleting namespace: $ns" | ||
| oc delete namespace --force "$ns" --wait=true --timeout=60s || true |
There was a problem hiding this comment.
i am thinking, why are we scripting this? can we write a small go based program to delete the namespaces?
There was a problem hiding this comment.
Why? That's way easier with existing tools to just find namespace to delete and delete them, no?
There was a problem hiding this comment.
i was just thinking that we have one less bash script 😆 no hard opinion here tbh.
There was a problem hiding this comment.
Ok, I see :) Then let's keep it as is
igor-karpukhin
force-pushed
the
CLOUDP-221656/openshift-cleaner
branch
from
de042a2 to
e4bd923
Compare
Summary
Added an openshift test cleaner to the regular cleaner job
Checklist