CLOUDP-321942: Enable support to GCP resources at Atlas Gov #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
force-pushed
the
CLOUDP-321942-ako-gov-gcp
branch
from
4659acf to
fe70c79
Compare
s-urbaniak
reviewed
Jun 3, 2025
| @@ -254,19 +248,6 @@ func advancedInstanceSizeInRange(currentInstanceSize, minInstanceSize, maxInstan | |||
| return nil | |||
| } | |||
|
|
|||
| func deploymentForGov(spec *akov2.AdvancedDeploymentSpec, regionUsageRestrictions string) error { | |||
There was a problem hiding this comment.
deleted code is the best code 😍
josvazg
reviewed
Jun 3, 2025
josvazg
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove validations constraints related to Gov and enable support for GCP. It let Atlas handle validations and forward back (through status) any error reported by Atlas.
Proof of Work
Tested against cloud-qa Gov.
E2E test is not possible once GCP doesn't have FedRamp-like regions and we don't have a GCP Gov account.
Checklist
Reminder (Please remove this when merging)