Skip to content

CLOUDP-323996: Fix make multiarch image #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jun 11, 2025

Summary

This fixes the Makefile to produce multi-arch images, just like the CI already does:

  1. Create a multiarch-builder buildx builder configured to support multi architecture builds.
  2. Build & push using multiarch-builder buildx builder for all target platforms at once.

Proof of Work

Command make image VERSION=... produced a proper prerelease multi-archi image as expected.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@josvazg josvazg requested a review from a team as a code owner June 11, 2025 09:52
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT with one nit: the image target is also used for local builds. So, I'd create a new one image-multiarch and make our CI to use it, since we don't need a multiarch image for local tests

@josvazg
Copy link
Collaborator Author

josvazg commented Jun 12, 2025

LGMT with one nit: the image target is also used for local builds. So, I'd create a new one image-multiarch and make our CI to use it, since we don't need a multiarch image for local tests

yes, I will leave the image target as it was and move the fix to a new key image-multiarch: as suggested

@josvazg josvazg force-pushed the CLOUDP-323996/fix-make-multiarch-image branch from 9c58c45 to d943a84 Compare June 12, 2025 14:40
@josvazg josvazg merged commit 56fa397 into main Jun 13, 2025
19 checks passed
@josvazg josvazg deleted the CLOUDP-323996/fix-make-multiarch-image branch June 13, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants