style: Sync tooling configuration from 4.0 branch (#2553)

Update ESLint and bring in a modified version of our config from 4.0. 
ESLint manages running and checking prettier formatting. 
Update mocha and bringing in the config from the 4.0 branch.

Author: nbbeeken

.eslintrc

@@ -0,0 +1,25 @@
+{
+  "root": true,
+  "parserOptions": {
+    "ecmaVersion": 2017
+  },
+  "plugins": [
+    "prettier"
+  ],
+  "extends": [
+    "eslint:recommended",
+    "plugin:prettier/recommended"
+  ],
+  "env": {
+    "node": true,
+    "mocha": true,
+    "es6": true
+  },
+  "rules": {
+    "prettier/prettier": "error",
+
+    "no-console": "off",
+    "eqeqeq": ["error", "always", { "null": "ignore" }],
+    "strict": ["error", "global"]
+  }
+}

.eslintrc.json

@@ -18,4 +18,4 @@ export NVM_DIR="${PROJECT_DIRECTORY}/node-artifacts/nvm"
 MONGODB_UNIFIED_TOPOLOGY=${UNIFIED} \
 OCSP_TLS_SHOULD_SUCCEED=${OCSP_TLS_SHOULD_SUCCEED} \
 CA_FILE=${CA_FILE} \
-npx mocha --opts '{}' test/manual/ocsp_support.test.js
+npx mocha --no-config test/manual/ocsp_support.test.js

.evergreen/run-ocsp-tests.sh

@@ -0,0 +1,7 @@
+{
+  "extension": ["js"],
+  "file": "test/tools/runner",
+  "ui": "test/tools/runner/metadata_ui.js",
+  "recursive": true,
+  "timeout": 60000
+}

.mocharc.json

@@ -0,0 +1,7 @@
+{
+  "singleQuote": true,
+  "tabWidth": 2,
+  "printWidth": 100,
+  "arrowParens": "avoid",
+  "trailingComma": "none"
+}

.prettierrc.json

@@ -95,7 +95,7 @@ const VALID_POOL_OPTIONS = new Set([
 
 function resolveOptions(options, defaults) {
   const newOptions = Array.from(VALID_POOL_OPTIONS).reduce((obj, key) => {
-    if (options.hasOwnProperty(key)) {
+    if (Object.prototype.hasOwnProperty.call(options, key)) {
       obj[key] = options[key];
     }
 

lib/cmap/connection_pool.js

@@ -250,6 +250,7 @@ class TopologyDescription {
     if (descriptionsWithError.length > 0) {
       return descriptionsWithError[0].error;
     }
+    return undefined;
   }
 
   /**

lib/core/sdam/topology_description.js

@@ -389,7 +389,7 @@ var eventHandler = function(self, event) {
       event === 'timeout' ||
       event === 'reconnect' ||
       event === 'attemptReconnect' ||
-      'reconnectFailed'
+      event === 'reconnectFailed'
     ) {
       // Remove server instance from accounting
       if (

lib/core/topologies/server.js

@@ -153,6 +153,7 @@ var GridStore = function GridStore(db, id, filename, mode, options) {
     },
     set: function(value) {
       if (!(this.mode[0] === 'w' && this.position === 0 && this.uploadDate == null)) {
+        // eslint-disable-next-line no-self-assign
         this.internalChunkSize = this.internalChunkSize;
       } else {
         this.internalChunkSize = value;

lib/gridfs/grid_store.js

@@ -39,7 +39,7 @@ function validateCollection(admin, collectionName, options, callback) {
 
   // Decorate command with extra options
   for (let i = 0; i < keys.length; i++) {
-    if (options.hasOwnProperty(keys[i]) && keys[i] !== 'session') {
+    if (Object.prototype.hasOwnProperty.call(options, keys[i]) && keys[i] !== 'session') {
       command[keys[i]] = options[keys[i]];
     }
   }

lib/operations/admin_ops.js

@@ -8,7 +8,7 @@ class ValidateCollectionOperation extends CommandOperation {
     let command = { validate: collectionName };
     const keys = Object.keys(options);
     for (let i = 0; i < keys.length; i++) {
-      if (options.hasOwnProperty(keys[i]) && keys[i] !== 'session') {
+      if (Object.prototype.hasOwnProperty.call(options, keys[i]) && keys[i] !== 'session') {
         command[keys[i]] = options[keys[i]];
       }
     }

lib/operations/validate_collection.js

@@ -565,7 +565,10 @@ function deprecateOptions(config, fn) {
     }
 
     config.deprecatedOptions.forEach(deprecatedOption => {
-      if (options.hasOwnProperty(deprecatedOption) && !optionsWarned.has(deprecatedOption)) {
+      if (
+        Object.prototype.hasOwnProperty.call(options, deprecatedOption) &&
+        !optionsWarned.has(deprecatedOption)
+      ) {
         optionsWarned.add(deprecatedOption);
         const msg = msgHandler(config.name, deprecatedOption);
         emitDeprecationWarning(msg);