style: Sync tooling configuration from 4.0 branch #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESLint and bring in a modified version of our config from 4.0. ESLint manages running and checking prettier formatting. Also updating mocha and bringing in the config from the 4.0 branch. Replace hasOwnProperty direct calls with indirect Object.prototype calls.
reggi
approved these changes
Sep 29, 2020
mbroadst
approved these changes
Sep 30, 2020
.eslintrc.json
Outdated
| ], | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "prettier/@typescript-eslint", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESLint and bring in a modified version of our config from 4.0. ESLint now manages running and checking prettier formatting so switching branches should be a more pleasant experience. Also updating mocha and bringing in the config from the 4.0 branch provides a similar convenience.
Fixed a few linter errors most of which were replace
hasOwnPropertydirect calls with indirectObject.prototype.hasOwnProperty.calls.