Skip to content

NODE-2692: Increase linting strictness #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Conversation

nbbeeken
Copy link
Contributor

Remove most of the disabled lint rules and correct the resulting errors.

@nbbeeken nbbeeken changed the title chore: increase linting strictness NODE-2692: Increase linting strictness Aug 27, 2020
@nbbeeken nbbeeken force-pushed the NODE-2692/stricter-linting branch from 6b54856 to b03251a Compare August 27, 2020 22:00
@nbbeeken nbbeeken force-pushed the NODE-2692/stricter-linting branch from b03251a to 5dcd36d Compare August 27, 2020 22:23
@nbbeeken nbbeeken marked this pull request as ready for review August 27, 2020 22:40
@nbbeeken nbbeeken requested a review from mbroadst August 27, 2020 22:40
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments, but really LGTM! Excited to call it a day on this business 😅

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a change request in there but also am just approving this now.

@nbbeeken nbbeeken requested review from reggi and emadum September 1, 2020 14:17
@nbbeeken nbbeeken merged commit 9bc8f64 into master Sep 1, 2020
@nbbeeken nbbeeken deleted the NODE-2692/stricter-linting branch September 1, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants