Skip to content

refactor: have FindOneOperation extend CommandOperation #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

refactor: have FindOneOperation extend CommandOperation #2604

merged 1 commit into from
Nov 4, 2020

Conversation

HanaPearlman
Copy link
Contributor

This PR changes FindOneOperation so it extends CommandOperation instead of OperationBase.

Recently, FindOperation was modified to extend CommandOperation as well, so this change is partially for symmetry and partially because it may help simplify the work required for implementing explain functionality on both operations.

NODE-2852/NODE-2853

@HanaPearlman HanaPearlman mentioned this pull request Nov 3, 2020
Merged
emadum
emadum approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HanaPearlman HanaPearlman merged commit f921132 into mongodb:master Nov 4, 2020
@HanaPearlman HanaPearlman deleted the NODE-2852/master/move-findone-under-command branch November 4, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@mbroadst mbroadst mbroadst approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HanaPearlman @emadum @mbroadst