refactor: all write commands now inherit from CommandOperation #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
reviewed
Dec 8, 2020
This patch moves the command construction for write operations from the wire protocol layer to the operation layer. Specifically, the insert/update/delete operations, which are also shared by the bulk implementation, are now the primary sites for write command construction. This has a few implications, primarily that you can no longer "write" with a `Server` instance, you can only execute a write operation against it. NODE-2953
mbroadst
force-pushed
the
NODE-2953/remove-write-command
branch
from
4f38dd0 to
93f1358
Compare
emadum
approved these changes
Dec 9, 2020
| @@ -54,6 +54,8 @@ describe('Aggregation', function () { | |||
| var collection = db.collection('shouldCorrectlyExecuteSimpleAggregationPipelineUsingArray'); | |||
| // Insert the docs | |||
| collection.insertMany(docs, { w: 1 }, function (err, result) { | |||
| if (err) console.dir(err); | |||
There was a problem hiding this comment.
Is this console.dir left over from debugging something?
There was a problem hiding this comment.
🙈 yeah it was, I'll correct that in the following PR just so we don't pay another CI round for this one
nbbeeken
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the command construction for write operations from the wire protocol layer to the operation layer. Specifically, the insert/update/delete operations, which are also shared by the bulk implementation, are now the primary sites for write command construction. This has a few implications, primarily that you can no longer "write" with a
Serverinstance, you can only execute a write operation against it.NODE-2953