Skip to content

refactor: remove db cache #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

refactor: remove db cache #2672

merged 1 commit into from
Dec 10, 2020

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Dec 9, 2020

Caching has been removed from MongoClient.db.

returnNonCachedInstance is now the default behavior and is
no longer a supported option.

NODE-2931

@emadum emadum marked this pull request as ready for review December 9, 2020 20:22
@emadum emadum requested review from nbbeeken and mbroadst December 9, 2020 20:22
mbroadst
mbroadst approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@aherlihy aherlihy mentioned this pull request Dec 10, 2020
Merged
nbbeeken
nbbeeken approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@emadum emadum merged commit 543fb00 into master Dec 10, 2020
@emadum emadum deleted the NODE-2931/remove-db-caching branch December 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbroadst mbroadst mbroadst approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @mbroadst @nbbeeken