test: more Unified runner operations #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-2287/UnifiedTestFormat-4
branch
2 times, most recently
from
87d48fc to
fb049bf
Compare
Adds a number of operations, makes use of chai expect instead of boolean for assertions to track stack traces, adds session and bucket entity types. Passes utilClient through to operation functions which are" inlined into the operations map to get type checking to work. Modifies url helper function to make multipleMongoses detection work.
nbbeeken
force-pushed
the
NODE-2287/UnifiedTestFormat-4
branch
from
fb049bf to
7366597
Compare
|
Working on the few failures left, but shouldn't be drastic so I think this is ready for a look, thanks! |
Move runner into its own file
emadum
approved these changes
Feb 8, 2021
| throw new Error(`Assertions need ${error} to be a MongoError`); | ||
| // if statement asserts type for TS, expect will always fail | ||
| expect(error).to.be.instanceOf(MongoError); | ||
| return; | ||
| } | ||
|
|
||
| if (expected.errorCode) { |
There was a problem hiding this comment.
I think it'd be better to do if (expected.errorCode != null) here and in the other checks to allow for expectations with false-y values.
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Adds a number of operations, makes use of chai expect instead of boolean for assertions to track stack traces, adds session and bucket entity types. Passes utilClient through to operation functions which are inlined into the operations map to get type checking to work. Modifies url helper function to make multipleMongoses detection work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a number of operations, makes use of chai expect instead of boolean
for assertions to track stack traces, adds session and bucket entity
types. Passes utilClient through to operation functions which are"
inlined into the operations map to get type checking to work.
Modifies url helper function to make multipleMongoses detection work.