feat(NODE-2992): consider server load during server selection #3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove .only staging for switch branches fix: apply localthreshold default of 15ms test: add integration test for localThresholdMS remove unit tests fix test descriptions test: add test runner && failing as expected refactor: misc cleanup in new test file passing unit tests feat: add new prose test for server selection add rough prose test add runonrequirements here we are clean up new prose test add steps to prose test fix: decrement operation count after failing to checkout a connection misc changes - prepare for commit fix up unit tests wrap up work
baileympearson
commented
Apr 26, 2022
baileympearson
commented
Apr 26, 2022
baileympearson
commented
Apr 26, 2022
baileympearson
commented
Apr 26, 2022
nbbeeken
suggested changes
Apr 27, 2022
nbbeeken
reviewed
Apr 28, 2022
nbbeeken
reviewed
Apr 28, 2022
dariakp
requested changes
Apr 29, 2022
test/integration/server-selection/server_selection_operation_count.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/server-selection/server_selection_operation_count.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
previously approved these changes
Apr 29, 2022
nbbeeken
previously approved these changes
Apr 29, 2022
nbbeeken
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR updates server selection to consider the number of operations running against a particular server.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
This is a part of the avoiding connection storms epic. Keeping track of the current server load will allow server selection to choose servers with fewer request being sent to them and help prevent connection storms.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>